Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-03 Thread Chiu, Chasel
hael D > Sent: Tuesday, May 2, 2023 10:39 PM > To: Chiu, Chasel ; devel@edk2.groups.io; > quic_llind...@quicinc.com > Cc: Lin, Benny ; Gao, Liming > ; Liu, Zhiguang ; Pedro > Falcato ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-02 Thread Michael D Kinney
nd...@quicinc.com; Kinney, Michael D > > Cc: Lin, Benny ; Gao, Liming > ; Liu, Zhiguang ; > Pedro Falcato > Subject: RE: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library. > > > Thanks Leif! > To align with your suggestion I think we can define below MACROs in &

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-02 Thread Chiu, Chasel
> From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > >> Sent: Tuesday, April 25, 2023 10:22 PM > >> To: devel@edk2.groups.io; Kinney, Michael D ; > >> Leif Lindholm > >> Cc: Lin, Benny ; Leif Lindholm > >> ; Gao, Liming ; > Liu, > >>

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-02 Thread Leif Lindholm
devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Tuesday, April 25, 2023 10:22 PM To: devel@edk2.groups.io; Kinney, Michael D ; Leif Lindholm Cc: Lin, Benny ; Leif Lindholm ; Gao, Liming ; Liu, Zhiguang ; Pedro Falcato Subject: Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library. H

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-01 Thread Chiu, Chasel
Lindholm > Cc: Lin, Benny ; Leif Lindholm > ; Gao, Liming ; Liu, > Zhiguang ; Pedro Falcato > Subject: Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library. > > > Hello, > > Since platform may also define other FDT structures, this EDK2 library may not > b

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-25 Thread Chiu, Chasel
lm > ; Gao, Liming ; Liu, > Zhiguang ; Pedro Falcato ; > Kinney, Michael D > Subject: Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library. > > Hi Leif, > > Do you have a proposal or small example on what you want to see > in the library? > > Mike >

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-24 Thread Michael D Kinney
Gao, Liming ; Liu, > Zhiguang ; Pedro Falcato > Subject: Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library. > > Apologies, I was refactoring a git tree and switched off the world :) > > Well, being a bit late to the party ... my view is it would be > preferable if

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-24 Thread Leif Lindholm
Apologies, I was refactoring a git tree and switched off the world :) Well, being a bit late to the party ... my view is it would be preferable if we put the byteswapping in the library. The DT format is *defined* to be big-endian, 32-bit cells. So frankly, I have no problems with pushing respons

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-20 Thread Chiu, Chasel
indholm > > Cc: Gao, Liming ; Liu, Zhiguang > ; Pedro Falcato ; Kinney, > Michael D > Subject: Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library. > > Hi Leif, > > What is your opinion on FDT being big endian. > > Do we want the lib to help with that asp

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-20 Thread Michael D Kinney
Hi Leif, What is your opinion on FDT being big endian. Do we want the lib to help with that aspect, or leave it up to the consumer of the lib to convert as needed? Seems like an area that could be very error prone if we are not careful. Mike > -Original Message- > From: Lin, Benny

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-19 Thread Benny Lin
>-Original Message- >From: Kinney, Michael D >Sent: Thursday, April 20, 2023 5:04 AM >To: Lin, Benny ; devel@edk2.groups.io >Cc: Gao, Liming ; Liu, Zhiguang >; Pedro Falcato ; Kinney, >Michael D >Subject: RE: [PATCH v3 2/3] MdePkg: Support FDT library. > >Responses below > >Mike > >>

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-19 Thread Michael D Kinney
Responses below Mike > -Original Message- > From: Lin, Benny > Sent: Wednesday, April 19, 2023 10:12 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Pedro Falcato > Subject: RE: [PATCH v3 2/3] MdePkg: Support FDT library. > > Please find my feed

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-19 Thread Benny Lin
Please find my feedback below. We can remove FDT_RESERVE_ENTRY but keep FDT_NODE_HEADER, what do you think? QQQ Benny >-Original Message- >From: Kinney, Michael D >Sent: Wednesday, April 19, 2023 11:54 PM >To: Lin, Benny ; devel@edk2.groups.io >Cc: Gao, Liming ; Liu, Zhiguang >; Pedro

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-19 Thread Michael D Kinney
A few comments below. Mike > -Original Message- > From: Lin, Benny > Sent: Sunday, April 16, 2023 10:35 PM > To: devel@edk2.groups.io > Cc: Lin, Benny ; Kinney, Michael D > ; Gao, Liming > ; Liu, Zhiguang ; Pedro > Falcato > Subject: [PATCH v3 2/3] MdePkg: Support FDT library. > > Fr

[edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-16 Thread Benny Lin
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) and refer to LibcLib implementation by Pedro. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Acked