I'm still working on this! The last hurdle is fixing PatchCheck.py to
allow .rtf files written by Notepad etc. to be committed as-is, without
requiring line endings to be fixed, trailing whitespace to be removed etc.
Once that's in, I'll merge these two patches.
--
Rebecca Cran
On 10/17/2
Thanks! Since you're okay with it, as a BaseTools maintainer I'll go
ahead with that plan.
--
Rebecca
On 10/17/23 13:56, Joey Vagedes wrote:
While I’m not a maintainer, so I don’t have much say - I don’t see an
issue with your solution that rewrites the entire file as the small
change I mad
Unfortunately the patch doesn't pass CI because
BaseTools/UserManuals/GenFw_Utility_Man_Page.rtf contains trailing
whitespace.
I'm unsure whether I can manually fix it, or if I should open it in
LibreOffice and re-save it? Doing so appears to rewrite the entire file,
which might not be what's
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes wrote:
Automatically set the nxcompat flag in the DLL Characteristics field of
the Optional Header of the PE32+ image. For this flag to be set
automatically, the section alignment must be evenly divisible
by 4K (EFI_PAG
Sorry, I started working on this at the weekend but had problems with applying
patches. I’ll try and get back to it soon.
On Tue, Aug 1, 2023, at 9:57 AM, Joey Vagedes wrote:
> Hello BaseTools maintainers. I'm still looking for feedback and a
> review for the changes made to GenFw to automatical
Acked-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Joey Vagedes
> via groups.io
> 发送时间: 2023年7月13日 23:25
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran ; Liming Gao
> ; Bob Feng ; Yuwei Chen
>
> 主题: [edk2-devel] [PATCH v3 2/2] BaseTools: Ge
Automatically set the nxcompat flag in the DLL Characteristics field of
the Optional Header of the PE32+ image. For this flag to be set
automatically, the section alignment must be evenly divisible
by 4K (EFI_PAGE_SIZE) and no section must be executable and writable.
Adds a command line flag to Ge
