Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-12-11 Thread Chao Li
*Cc:* Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann ; Leif Lindholm ; Ard Biesheuvel ; Sami Mujawar ; Sunil V L ; Warkentin, Andrei *Subject:* Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg Hi Ray, Do you think this plan is OK? If possible, I will submit the V4

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-12-11 Thread Ni, Ray
Mujawar ; Sunil V L ; Warkentin, Andrei Subject: Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg Hi Ray, Do you think this plan is OK? If possible, I will submit the V4 today. Thanks, Chao On 2023/12/5 20:27, Chao Li wrote: Hi Ray, On 2023/12/5 16:27, Ni, Ray wrote

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-12-07 Thread Chao Li
:* devel@edk2.groups.io; Ni, Ray *Cc:* Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann ; Leif Lindholm ; Ard Biesheuvel ; Sami Mujawar ; Sunil V L ; Warkentin, Andrei *Subject:* Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg Hi Ray, For this patch, I checked again and

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-12-05 Thread Chao Li
Mujawar ; Sunil V L ; Warkentin, Andrei *Subject:* Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg Hi Ray, For this patch, I checked again and here are my opinions: 1. (Set|Get)MemoryRegionAttribute is difficult to merge together, because the parameters

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-12-05 Thread Ni, Ray
] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg Hi Ray, For this patch, I checked again and here are my opinions: 1. (Set|Get)MemoryRegionAttribute is difficult to merge together, because the parameters between the tow APIs are not similar. So I suggest they be independent. [Ray

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-12-03 Thread Chao Li
Hi Ray, For this patch, I checked again and here are my opinions: 1. (Set|Get)MemoryRegionAttribute is difficult to merge together, because the parameters between the tow APIs are not similar. So I suggest they be independent. 2. The EfiAttributeConverse, GetMemoryRegionAttribute, SetMemory

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-11-29 Thread Chao Li
Hi Ray, Thanks for review, here are some of my thoughts: Thanks, Chao On 2023/11/30 08:59, Ni, Ray wrote: Chao, Since the lib class is so general, I'd like to understand more details to make sure it can properly fit into any CPU arch. In X86, cache setting is through MSRs and Page tables, an

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-11-29 Thread Ni, Ray
Chao, Since the lib class is so general, I'd like to understand more details to make sure it can properly fit into any CPU arch. In X86, cache setting is through MSRs and Page tables, and memory access control (read-only, not-present, non-executable) is through page tables. This CpuMmuLib is to

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-11-19 Thread Chao Li
Hi Anderi, There are indeed typos and I will fix them in V4. Thank you! Thanks, Chao On 2023/11/18 04:18, Andrei Warkentin wrote: +Tuan as a heads-up. This seems reasonable to me. What does the "Uint" mean in ConfigureMemoryManagementUint? Did you intend to say "Unit"? Reviewed-by: Andrei

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-11-17 Thread Andrei Warkentin
+Tuan as a heads-up. This seems reasonable to me. What does the "Uint" mean in ConfigureMemoryManagementUint? Did you intend to say "Unit"? Reviewed-by: Andrei Warkentin > -Original Message- > From: Chao Li > Sent: Friday, November 17, 2023 4:00 AM > To: devel@edk2.groups.io > Cc: Do

[edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-11-17 Thread Chao Li
Add a new header file CpuMmuLib.h, whitch is referenced from ArmPkg/Include/Library/ArmMmuLib.h. Currently, only support for LoongArch64 is added, and more architectures can be accommodated in the future. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Eric Dong Cc: Ray Ni Cc: Rahul