Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-10-05 Thread Ard Biesheuvel
On Thu, 9 Sept 2021 at 12:58, Gerd Hoffmann wrote: > > > > Sure. Suggestions? Add a Pcd and set it in Microvm.dsc? > > > Or is there some better way? > > > > It's all a question of how much we want to overengineer things :) > > > > I'm tempted to suggest a balanced version would be adding > >

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-09 Thread Gerd Hoffmann
> > Sure. Suggestions? Add a Pcd and set it in Microvm.dsc? > > Or is there some better way? > > It's all a question of how much we want to overengineer things :) > > I'm tempted to suggest a balanced version would be adding > GCC: *_*_*_CC_FLAGS = -D PLATFORM_IS_MICROVM > to [BuildOptions] i

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Leif Lindholm
On Wed, Sep 08, 2021 at 13:33:51 +0200, Gerd Hoffmann wrote: > On Wed, Sep 08, 2021 at 12:06:46PM +0100, Leif Lindholm wrote: > > On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote: > > > Skip host bridge setup on microvm. > > > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=35

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Gerd Hoffmann
On Wed, Sep 08, 2021 at 12:06:46PM +0100, Leif Lindholm wrote: > On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote: > > Skip host bridge setup on microvm. > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 > > Signed-off-by: Gerd Hoffmann > > Acked-by: Jiewen Yao > > ---

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Leif Lindholm
On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote: > Skip host bridge setup on microvm. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 > Signed-off-by: Gerd Hoffmann > Acked-by: Jiewen Yao > --- > OvmfPkg/PlatformPei/MemDetect.c | 4 > 1 file changed, 4 insertions(+

[edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Gerd Hoffmann
Skip host bridge setup on microvm. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/PlatformPei/MemDetect.c | 4 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDete