Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg:Add variable store is full debug info

2023-09-20 Thread Zhenyu Zhang
> I don't think a full variable store is the only reason we might end up > with EFI_OUT_OF_RESOURCES here, so this message could be misleading. > > Given that this is a DEBUG build, I'd expect the developer to be able > to infer from the context that this might be either an out of memory > or an ou

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg:Add variable store is full debug info

2023-09-13 Thread Ard Biesheuvel
On Mon, 11 Sept 2023 at 04:47, Zhenyu Zhang wrote: > > From: "Zhenyu Zhang" > > We observed that EDK2 hits an ASSERT (Out of Resources) when > booting with a full variable store. The message provided in > this case is not helpful for non-experts. > Add debug information to help users understand w

[edk2-devel] [PATCH v3 1/1] OvmfPkg:Add variable store is full debug info

2023-09-10 Thread Zhenyu Zhang
From: "Zhenyu Zhang" We observed that EDK2 hits an ASSERT (Out of Resources) when booting with a full variable store. The message provided in this case is not helpful for non-experts. Add debug information to help users understand what caused the assertion. Actual results: RecordVarErrorFlag (