Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
W dniu 7.04.2023 o 15:40, Pedro Falcato pisze: (+cc old CCs) (Marcin, you're dropping CC's on your replies) Oops, sorry. ASM files that require preprocessing should have a capital S here (.S vs .s) After renaming it to readregs.S (and changing in ArmCpuInfo.inf) I get: build.py... /home/m

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
Oops, now I screwed up the CC's, apologies. On Fri, Apr 7, 2023 at 2:40 PM Pedro Falcato wrote: > > (+cc old CCs) > > (Marcin, you're dropping CC's on your replies) > > On Fri, Apr 7, 2023 at 2:29 PM Marcin Juszkiewicz > wrote: > > > > W dniu 7.04.2023 o 15:02, Pedro Falcato pisze: > > > > >> di

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
(+cc old CCs) (Marcin, you're dropping CC's on your replies) On Fri, Apr 7, 2023 at 2:29 PM Marcin Juszkiewicz wrote: > > W dniu 7.04.2023 o 15:02, Pedro Falcato pisze: > > >> diff --git a/ArmPkg/Application/ArmCpuInfo/readregs.s > >> b/ArmPkg/Application/ArmCpuInfo/readregs.s > > > > ASM files

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
W dniu 7.04.2023 o 15:02, Pedro Falcato pisze: +EFI_STATUS +EFIAPI +UefiMain ( + IN EFI_HANDLEImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + UINT64 aa64dfr0_el1 = read_aa64dfr0_el1 (); + UINT64 aa64dfr1_el1 = read_aa64dfr1_el1 (); + UINT64 aa64isar0_el1 = read_aa64

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
Forgot mentioning: STATIC vs static, CONST vs const, VOID vs void, CHAR8 vs char, etc. All fun microsoftisms you need to use here. On Fri, Apr 7, 2023 at 2:02 PM Pedro Falcato wrote: > > On Fri, Apr 7, 2023 at 1:47 PM Marcin Juszkiewicz > wrote: > > > > App goes through ID_AA64*_EL1 system regis

Re: [edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Pedro Falcato
On Fri, Apr 7, 2023 at 1:47 PM Marcin Juszkiewicz wrote: > > App goes through ID_AA64*_EL1 system registers and decode their values. > > Signed-off-by: Marcin Juszkiewicz > --- > ArmPkg/ArmPkg.dsc|1 + > ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 38 + > Arm

[edk2-devel] [PATCH v3] add ArmCpuInfo EFI application

2023-04-07 Thread Marcin Juszkiewicz
App goes through ID_AA64*_EL1 system registers and decode their values. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/ArmPkg.dsc|1 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 38 + ArmPkg/Application/ArmCpuInfo/readargs.h | 12 + ArmPkg/Application/Ar