Re: [edk2-devel] [PATCH v3] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-31 Thread Ni, Ray
-*GopBlt = AllocatePool (*GopBltSize); +*GopBlt = AllocatePages (*GopBltSize); It doesn't look right. You cannot pass in the same value origilly passed to AllocatePool(). Thanks, Ray From: Ck, Chitralekha Sent: Thursday, August 3, 2023 5:29 PM To

Re: [edk2-devel] [PATCH v3] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-04 Thread Mike Maslenkin
Very nice, that functional changes were separated. But, as far as I remember, Pedro noticed that AllocatePages() takes number of pages, not a bytes. So, the change could be as: *GopBlt = AllocatePages (EFI_SIZE_TO_PAGES(*GopBltSize)); But I I would like you to pay special attention that this

[edk2-devel] [PATCH v3] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-04 Thread chitralekha ck
https://bugzilla.tianocore.org/show_bug.cgi?id=4507 AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. AllocatePool() is being avoided due to its 64k allocation size limit when the library is incorporated into a PEI component. Cc: Ray Ni Cc: Zhichao Gao Cc: Ashraf Ali S Cc: C