Re: [edk2-devel] [PATCH v2 6/6] UefiCpuPkg/MtrrLib: use new IS_POW2() macro.

2023-03-22 Thread Michael D Kinney
vin Häuser ; > Pawel Polawski ; Michael Roth > ; Tom Lendacky ; Gerd Hoffmann > ; Yao, Jiewen > ; Wang, Jian J ; Ard Biesheuvel > ; Justen, Jordan L > ; Wu, Hao A ; Liu, Zhiguang > ; Ni, Ray ; > Xu, Min M ; Oliver Steffen > Subject: [edk2-devel] [PATCH v2 6/6] UefiCpuPk

Re: [edk2-devel] [PATCH v2 6/6] UefiCpuPkg/MtrrLib: use new IS_POW2() macro.

2023-03-22 Thread Ni, Ray
Reviewed-by: Ray Ni thanks, ray From: Gerd Hoffmann Sent: Wednesday, March 22, 2023 3:02:43 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Aktas, Erdem ; James Bottomley ; Gao, Liming ; Marvin Häuser ; Pawel Polawski ; Michael Roth ; Tom Lendacky ; Gerd

[edk2-devel] [PATCH v2 6/6] UefiCpuPkg/MtrrLib: use new IS_POW2() macro.

2023-03-22 Thread Gerd Hoffmann
Drop MtrrLibIsPowerOfTwo function, use the new IS_POW2() macro instead. The ASSERT() removed (inside MtrrLibIsPowerOfTwo) is superfluous, another ASSERT() a few lines up in MtrrLibCalculateMtrrs() already guarantees that Length can not be zero at this point. Signed-off-by: Gerd Hoffmann --- Uef