Re: [edk2-devel] [PATCH v2 3/6] SecurityPkg: Add SecureBootDefaultKeysDxe driver

2021-06-04 Thread Sunny Wang
Internally reviewed this patch before sending the edk2 mailing list and It looks good to me. Please also address Pete's good catches/comments. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Tuesday, June 1, 2021 9:12 PM To: devel@edk2.groups.io Cc: l...@nuviain

Re: [edk2-devel] [PATCH v2 3/6] SecurityPkg: Add SecureBootDefaultKeysDxe driver

2021-06-04 Thread Min Xu
On June 1, 2021 9:12 PM, Grzegorz Bernacki Wrote: > This driver initializes default Secure Boot keys and databases based on keys > embedded in flash. > > Signed-off-by: Grzegorz Bernacki > --- > > SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootD > efaultKeysDxe.inf | 46 +++

Re: [edk2-devel] [PATCH v2 3/6] SecurityPkg: Add SecureBootDefaultKeysDxe driver

2021-06-02 Thread Pete Batard
3 very minor remarks below: On 2021.06.01 14:12, Grzegorz Bernacki wrote: This driver initializes default Secure Boot keys and databases based on keys embedded in flash. Signed-off-by: Grzegorz Bernacki --- SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootDefaultKeysDxe.

[edk2-devel] [PATCH v2 3/6] SecurityPkg: Add SecureBootDefaultKeysDxe driver

2021-06-01 Thread Grzegorz Bernacki
This driver initializes default Secure Boot keys and databases based on keys embedded in flash. Signed-off-by: Grzegorz Bernacki --- SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootDefaultKeysDxe.inf | 46 + SecurityPkg/VariableAuthenticated/SecureBootDefaultK