Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-08-09 Thread Girish Mahadevan via groups.io
Hi Sami, Any chance we can try to get your dispatcher patches in for the upcoming release.(if there are no other comments). Best Regards Girish On 7/25/2023 5:29 PM, Girish Mahadevan via groups.io wrote: External email: Use caution opening links or attachments Hi Sami My responses inline

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-07-25 Thread Girish Mahadevan via groups.io
Hi Sami My responses inline [GM] Best Regards Girish On 7/24/2023 11:48 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Hi Girish, Thank you for taking this effort forward Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 22/07/2023

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-07-24 Thread Sami Mujawar
Hi Girish, Thank you for taking this effort forward Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 22/07/2023 12:14 am, Girish Mahadevan wrote: Hi Sami Your patches worked. There was just one thing I had to add to get compile to work. (inline with [GM]), other than

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-07-21 Thread Girish Mahadevan via groups.io
Hi Sami Your patches worked. There was just one thing I had to add to get compile to work. (inline with [GM]), other than that I think you can get this in. We've implemented about 18 table generators. (Types 0, 1, 2, 3, 8, 9, 11, 13, 14, 16, 17, 19, 32, 38, 39, 41, 43, 45) Two more are und

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-03-10 Thread Sami Mujawar
Hi Girish, On 10/03/2023 04:23 pm, Girish Mahadevan wrote: Hi Sami Response inline.[GM] Best Regards Girish On 3/9/2023 3:41 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Hi Girish, Thank you for your feedback. Please find my response inline marked [SAM

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-03-10 Thread Girish Mahadevan via groups.io
Hi Sami Response inline.[GM] Best Regards Girish On 3/9/2023 3:41 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Hi Girish, Thank you for your feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 08/03/2023, 17:41, "Girish M

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-03-09 Thread Sami Mujawar
Hi Girish, Thank you for your feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 08/03/2023, 17:41, "Girish Mahadevan" mailto:gmahade...@nvidia.com>> wrote: Hi Sami Thanks for v2, I will apply these to my tree and test it out. One small comment before I revie

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-03-08 Thread Girish Mahadevan via groups.io
Hi Sami Thanks for v2, I will apply these to my tree and test it out. One small comment before I review/test the patch train inline (prefixed by [GM]) Best Regards Girish On 3/8/2023 1:16 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Some SMBIOS structure

[edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-03-08 Thread Sami Mujawar
Some SMBIOS structure/table fields have dependency on other SMBIOS structures/tables. These dependencies are established using handles pointing to the dependent tables. A SMBIOS table handle can be obtained by either installing a SMBIOS table or by allocating a handle, which requires complex manag