Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg: Handle Cloud Hypervisor host bridge

2021-12-06 Thread Gerd Hoffmann
Hi, > STATIC UINT16 mAcpiPmBaseAddress; > +STATIC UINT16 mAcpiHwReducedSleepCtl; > > EFI_STATUS > EFIAPI > @@ -26,6 +27,7 @@ DxeResetInit ( > { >UINT16 HostBridgeDevId; > > + mAcpiPmBaseAddress = 0; Hmm? mAcpiPmBaseAddress + mAcpiHwReducedSleepCtl should be treated equal here (zer

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg: Handle Cloud Hypervisor host bridge

2021-12-04 Thread Yao, Jiewen
Is below code right? + case CLOUDHV_DEVICE_ID: mRegisterValues = mRegisterValuesQ35; +case CLOUDHV_DEVICE_ID: mLegacyInterruptDevice = LEGACY_INT_DEV_Q35; I am not sure if it is the best pattern to describe which register is reused from Q35, and which one is CV specific. Mayb

[edk2-devel] [PATCH v2 1/5] OvmfPkg: Handle Cloud Hypervisor host bridge

2021-12-04 Thread sebastien . boeuf
From: Sebastien Boeuf Handle things differently when the detected host bridge matches the Cloud Hypervisor PCI host bridge identifier. Signed-off-by: Rob Bradford Signed-off-by: Sebastien Boeuf --- OvmfPkg/Csm/CsmSupportLib/LegacyInterrupt.c | 1 + OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c