Re: [edk2-devel] [PATCH v2 1/4] Platform/RaspberryPi: Add Negative table check

2021-02-08 Thread Andrei Warkentin
Reviewed-by: Andrei Warkentin From: Pete Batard Sent: Monday, February 8, 2021 11:08 AM To: Jeremy Linton ; devel@edk2.groups.io Cc: Andrei Warkentin ; samer.el-haj-mahm...@arm.com ; l...@nuviainc.com ; ardb+tianoc...@kernel.org Subject: Re: [PATCH v2 1/4] Pl

Re: [edk2-devel] [PATCH v2 1/4] Platform/RaspberryPi: Add Negative table check

2021-02-08 Thread Pete Batard
Looks good to me. On 2021.02.01 22:53, Jeremy Linton wrote: Turns out its helpful to have a !PcdToken flag that enables a DSDT/SSDT. That simplifies both the emmc2 SSDT (it only installs when !SdIsArasan) and later for the XHCI/PCIe switch where we want to install one of two tables depending on

[edk2-devel] [PATCH v2 1/4] Platform/RaspberryPi: Add Negative table check

2021-02-01 Thread Jeremy Linton
Turns out its helpful to have a !PcdToken flag that enables a DSDT/SSDT. That simplifies both the emmc2 SSDT (it only installs when !SdIsArasan) and later for the XHCI/PCIe switch where we want to install one of two tables depending on whether a single Pcd is set. Signed-off-by: Jeremy Linton ---