edk2-devel-groups-io ; Jeff Brasen
Subject: Re: [edk2-devel] [PATCH v2 1/2] Ext4Pkg: Improve
Ext4IsBindingSupported() behavior
External email: Use caution opening links or attachments
On 10/09/2021 19:08, Pedro Falcato wrote:
> Ah yes, thanks! Although I didn't find the part where they s
On 10/09/2021 19:08, Pedro Falcato wrote:
Ah yes, thanks! Although I didn't find the part where they say that
you need to use the same attributes,
after re-reading the spec it seems they recommend using BY_DRIVER.
UEFI 2.9, 11.1, "Device Driver", 2.: "It must use the same Attribute
value that
Ah yes, thanks! Although I didn't find the part where they say that
you need to use the same attributes,
after re-reading the spec it seems they recommend using BY_DRIVER.
So, change it to BY_DRIVER. The performance should be the same and
it's more consistent.
On Fri, Sep 10, 2021 at 5:56 PM Marv
little changes as well once I get a desired direction on
how to open BlockIo.
Thanks,
Jeff
From: Marvin Häuser
Sent: Friday, September 10, 2021 10:56 AM
To: devel@edk2.groups.io ; pedro.falc...@gmail.com
; Jeff Brasen
Subject: Re: [edk2-devel] [PATCH v2 1/2
On 10/09/2021 18:52, Pedro Falcato wrote:
Like Marvin raised in v1, it's a good idea to change the first
OpenProtocol's EFI_OPEN_PROTOCOL_BY_DRIVER
into EFI_OPEN_PROTOCOL_GET_PROTOCOL, for consistency's sake.
Since we're not keeping these protocols open, using BY_DRIVER makes no
difference.
No,
Like Marvin raised in v1, it's a good idea to change the first
OpenProtocol's EFI_OPEN_PROTOCOL_BY_DRIVER
into EFI_OPEN_PROTOCOL_GET_PROTOCOL, for consistency's sake.
Since we're not keeping these protocols open, using BY_DRIVER makes no
difference.
You didn't update Ext4SuperblockCheckMagic's com
A couple of improvements to improve performance.
Add check to return ACCESS_DENIED if already connected
Add check to verify superblock magic during supported to reduce start calls
Signed-off-by: Jeff Brasen
---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h| 14 +++
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.
