Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-29 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] We need a PR to trigger CI test and then maintainer can set the label to "Push" to merge the code if the change passes all CI tests. I think I done this way for a long time. Regards, Abner From: Ashish Singhal Sent: Thursday, November 30, 2023 10:16 AM To: C

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-29 Thread Ashish Singhal via groups.io
I thought the process was to share the patch via email and maintainers create the PR. Author creating PR used to be optional. Has that changed recently? Thanks Ashish Get Outlook for iOS From: Chang, Abner Sent: Wednesday, November 29, 202

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-29 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Ah sure. I can do it at anytime. Could you please create a PR for this change and let me know? Abner From: Ashish Singhal Sent: Thursday, November 30, 2023 12:37 AM To: Chang, Abner ; devel@edk2.groups.io; quic_llind...@quicinc.com; ardb+tianoc...@kernel.org

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-29 Thread Ashish Singhal via groups.io
Hello, Checking if there is a timeline for this patchset to be merged. Thanks Ashish From: Chang, Abner Sent: Monday, November 20, 2023 6:57 PM To: Ashish Singhal ; devel@edk2.groups.io ; quic_llind...@quicinc.com ; ardb+tianoc...@kernel.org ; g...@danielschae

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] >I did not add this intentionally and even sent out an email asking the same on >edk2-rfc if this should be done by maintainers unless you want me to do it as >a ??separate patch set. >Link to the message is https://edk2.groups.io/g/rfc/message/827 That's fine.

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-20 Thread Ashish Singhal via groups.io
From: Chang, Abner Sent: Monday, November 20, 2023 5:13 AM To: Ashish Singhal ; devel@edk2.groups.io ; quic_llind...@quicinc.com ; ardb+tianoc...@kernel.org ; g...@danielschaefer.me ; Jeff Brasen Subject: RE: [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Comma

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks for this update and two more comments, > -Original Message- > From: Ashish Singhal > Sent: Wednesday, November 15, 2023 11:12 AM > To: devel@edk2.groups.io; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org; Chang, Abner ; > g...@danielschaef

[edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-14 Thread Ashish Singhal via groups.io
Curently, AndroidBootImgLib expects input kernel command line to never exceed 256 unicode characters where the image header allows for 512 ascii characters. If image header allows 512 ascii characters, similar number of unicode characters should be allowed at the minimum. Signed-off-by: Ashish Sin