Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-06-12 Thread Gao, Zhichao
o: Gao, Zhichao ; devel@edk2.groups.io > Cc: Sami Mujawar ; Carsey, Jaben > ; Ni, Ray ; nd > Subject: Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update > for MADT parser > > Hi Zhichao, > > Please find my comments inline below. They are marked with [Krzys

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-06-12 Thread Sami Mujawar
Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 12 June 2019 11:44 AM To: Gao, Zhichao ; devel@edk2.groups.io Cc: Sami Mujawar ; Carsey, Jaben ; Ni, Ray ; nd Subject: RE: [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser Hi Zhichao, Please fi

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-06-12 Thread Krzysztof Koch
Hi Zhichao, Please find my comments inline below. They are marked with [Krzysztof] Kind regards, Krzysztof -Original Message- From: Gao, Zhichao Sent: Monday, June 10, 2019 2:08 To: Krzysztof Koch ; devel@edk2.groups.io Cc: Sami Mujawar ; Carsey, Jaben ; Ni, Ray ; Matteo Carlini ; S

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-06-09 Thread Gao, Zhichao
Sorry for late update. > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Friday, June 7, 2019 4:48 PM > To: devel@edk2.groups.io > Cc: sami.muja...@arm.com; Carsey, Jaben ; Ni, > Ray ; Gao, Zhichao ; > matteo.carl...@arm.com; stephanie.hughes-f...@arm.com;

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-06-07 Thread Sami Mujawar
Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 07 June 2019 09:48 AM To: devel@edk2.groups.io Cc: Sami Mujawar ; jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Matteo Carlini ; Stephanie Hughes-Fitt ; nd Subject: [PATCH v2 1/1] ShellPkg: a

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-06-07 Thread Alexei . Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42020): https://edk2.groups.io/g/devel/message/42020 Mute This Topic: https://groups.io/mt/31972729/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

[edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-06-07 Thread Krzysztof Koch
The ACPI 6.3 specification introduces a 'SPE overflow Interrupt' field as part of the GICC structure. Update the MADT parser to decode this field and validate the interrupt ID used. References: - ACPI 6.3 Specification - January 2019 - Arm Generic Interrupt Controller Architecture Specification,

[edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-05-30 Thread Krzysztof Koch
The ACPI 6.3 specification introduces a 'SPE overflow Interrupt' field as part of the GICC structure. Update the MADT parser to decode this field and validate the interrupt ID used. References: - ACPI 6.3 Specification - January 2019 - Arm Generic Interrupt Controller Architecture Specification,