Re: [edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

2020-03-02 Thread Dong, Eric
Hi Laszlo, Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 27, 2020 6:12 AM > To: edk2-devel-groups-io > Cc: Ard Biesheuvel ; Dong, Eric > ; Wu, Hao A ; Igor Mammedov > ; Wang, Jian J ; Yao, > Jiewen ; J

Re: [edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

2020-03-02 Thread Philippe Mathieu-Daudé
On 2/26/20 11:11 PM, Laszlo Ersek wrote: In the CoreStartImage() function [MdeModulePkg/Core/Dxe/Image/Image.c], if the image entry point returns a failure code, then the DXE Core logs a helpful DEBUG_ERROR message, with the following format string: "Error: Image at %11p start failed: %r\n"

Re: [edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

2020-03-02 Thread Liming Gao
g, > Jian J ; Ni, Ray > > Cc: edk2-devel-groups-io ; Ard Biesheuvel > ; Igor Mammedov > ; Yao, Jiewen ; Justen, Jordan L > ; Kinney, Michael D > ; Philippe Mathieu-Daudé > Subject: Re: [edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM > image start failu

Re: [edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

2020-03-02 Thread Laszlo Ersek
Jian, Hao, Eric, Ray, this patch is trivial; can one of you please ACK it? Thanks Laszlo On 02/26/20 23:11, Laszlo Ersek wrote: > In the CoreStartImage() function [MdeModulePkg/Core/Dxe/Image/Image.c], if > the image entry point returns a failure code, then the DXE Core logs a > helpful DEBUG_ER

[edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

2020-02-26 Thread Laszlo Ersek
In the CoreStartImage() function [MdeModulePkg/Core/Dxe/Image/Image.c], if the image entry point returns a failure code, then the DXE Core logs a helpful DEBUG_ERROR message, with the following format string: "Error: Image at %11p start failed: %r\n" Do similarly in the SMM Core (update the mes