Re: [edk2-devel] [PATCH v2 0/9] Need add a FSP binary measurement

2020-08-11 Thread Wang, Jian J
Hi Qi, Two common comments here. More specific comments will be given separately in each patch email later. c1. SecurityPkg/Library/DxeTpmMeasurementLib/EventLogRecord.c and SecurityPkg/Library/PeiTpmMeasurementLib/EventLogRecord.c are almost the same. Consider consolidating the code

Re: [edk2-devel] [PATCH v2 0/9] Need add a FSP binary measurement

2020-08-10 Thread Yao, Jiewen
Hi Qi Thanks for the update. 1) Since this is a new feature, a platform may already measure FSP binary in some ways, I recommend we change the default policy to: gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x. 2) We should not check FSP_MEASURE_FSP in IntelFsp2WrappePkg, bec

[edk2-devel] [PATCH v2 0/9] Need add a FSP binary measurement

2020-08-05 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 The EDKII BIOS calls FSP API in FSP Wrapper Pkg. This FSP code need to be measured into TPM. We need add a generic module in FSP Wrapper Pkg code to measure: 1) FSP-T, FSP-M, FSP-S in API mode. 2) FSP-T in Dispatch-mode. The FSP-M and FSP-S