Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-09-26 Thread Chiu, Chasel
8 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP > 2.4 MultiPhase. > > > patch3 Fsp24SecCore modules have been merged: > https://github.com/tianocore/edk2/c

Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-09-06 Thread Chiu, Chasel
: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP > 2.4 MultiPhase. > > > Patch1 and patch2 have been merged: > https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfe

Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-08-31 Thread Chiu, Chasel
Patch1 and patch2 have been merged: https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee96f462676e7 https://github.com/tianocore/edk2/commit/31a94f7fba2a2c1244fc35b6f631e235e267715b Rest of the patches will be merged later. Thanks, Chasel > -Original Message- > From:

Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-08-30 Thread Nate DeSimone
Hi Chasel, I have some minor feedback on PATCH 1/4. Specifically, some improvements are needed in the comments. The code itself looks good! For that reason, there is no need to send a V3 patch series. Please fix the comments then you are free to push the change. With those changes... Reviewed

[edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-08-09 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916 Add FSP 2.4 MultiPhase interfaces and implementation. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu V2: . Add FspMultiPhasePlatformGetNumberOfPhases() and FspWrapperPlatformMultiPhaseHandler() to support platform porting.