Re: [edk2-devel] [PATCH v2 0/2] Dynamic ACPI framework for fsl layerscape platforms

2021-02-19 Thread Vikas Singh via groups.io
On Tue, Feb 16, 2021 at 5:29 PM Vikas Singh wrote: > > On Mon, Feb 15, 2021 at 6:48 PM Leif Lindholm wrote: > > > > Hi Vikas, > > > > Apologies for very slow review. > > > > However, this set doesn't build for me. > > It fails with > > > > In file included from > > /work/git/edk2-platforms/Platf

Re: [edk2-devel] [PATCH v2 0/2] Dynamic ACPI framework for fsl layerscape platforms

2021-02-16 Thread Vikas Singh via groups.io
On Mon, Feb 15, 2021 at 6:48 PM Leif Lindholm wrote: > > Hi Vikas, > > Apologies for very slow review. > > However, this set doesn't build for me. > It fails with > > In file included from > /work/git/edk2-platforms/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager

Re: [edk2-devel] [PATCH v2 0/2] Dynamic ACPI framework for fsl layerscape platforms

2021-02-15 Thread Sami Mujawar
Hi Leif, Please find my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: Leif Lindholm Sent: 15 February 2021 01:18 PM To: Vikas Singh ; Sami Mujawar Cc: devel@edk2.groups.io; Meenakshi Aggarwal (meenakshi.aggar...@nxp.com) ; Paul Yang ; Augustine Phili

Re: [edk2-devel] [PATCH v2 0/2] Dynamic ACPI framework for fsl layerscape platforms

2021-02-15 Thread Leif Lindholm
Hi Vikas, Apologies for very slow review. However, this set doesn't build for me. It fails with In file included from /work/git/edk2-platforms/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c:26: /work/git/edk2-platforms/Platform/NXP/ConfigurationManagerPkg/Co

[edk2-devel] [PATCH v2 0/2] Dynamic ACPI framework for fsl layerscape platforms

2021-01-26 Thread Vikas Singh via groups.io
This patch series sets the foundation of Dynamic ACPI framework for all fsl layerscape platforms. In order to achieve: - Configurable firmware builds. - Unify firmware build for similar platforms. - Minimize/eliminate human induced errors. - Validate and generate firmware that complies with