Re: [edk2-devel] [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode devices

2019-04-22 Thread Ni, Ray
> -Original Message- > From: Wu, Hao A > Sent: Monday, April 22, 2019 10:18 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Dong, Eric ; Wang, Jian J > Subject: RE: [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode > devices > > > -Original Message- > > From: Ni, Ray > > S

Re: [edk2-devel] [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode devices

2019-04-22 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Tuesday, April 23, 2019 4:20 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Wang, Jian J > Subject: RE: [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode > devices > > Comments: > 1. Can we add EFI_PEI_PPI_DESCRIPTOR_TERMINATE

Re: [edk2-devel] [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode devices

2019-04-22 Thread Ni, Ray
Comments: 1. Can we add EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST to mAhciAtaPassThruPpiListTemplate/mAhciBlkIoPpiListTemplate as well? I understand that requires calling PeiServicesInstallPpi() 3 times instead of once. But I see the benefit of change is the code is more understandable and potentia

[edk2-devel] [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode devices

2019-04-09 Thread Wu, Hao A
The series is also available at: https://github.com/hwu25/edk2/tree/ahci_pei_blockio_v2 V2 changges: Due to the file license change, rebase the whole series onto the tip of the master branch. The 'Contributed-under' tag is removed from the log messages as well. V1 history: The series will add