Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-20 Thread Ni, Ray
OK. I see. I am fine with that. Reviewed-by: Ray Ni > -Original Message- > From: Guo, Gua > Sent: Tuesday, December 20, 2022 9:33 AM > To: Ni, Ray ; Liu, KasimX ; > devel@edk2.groups.io > Cc: Dong, Guo ; Lu, James > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD >

Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-19 Thread Guo, Gua
The goal reduce macro requirement to build UniversalPayloadBuild.py. For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate HOB data. So the change is move these PCD have compatibility FixedAtBuild only

[edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-19 Thread kasimx . liu
From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX

Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-18 Thread Ni, Ray
The initial goal was to remove dynamic PCD dependency from bootloader. Is that still the goal? If yes, maybe depending on dynamic PCD is not a good idea. Thanks, Ray > -Original Message- > From: Liu, KasimX > Sent: Monday, December 19, 2022 3:40 PM > To: devel@edk2.groups.io > Cc: Liu, K