Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-13 Thread Ashish Singhal via groups.io
Singhal ; Marc Zyngier ; Ard Biesheuvel ; Shanker Donthineni Cc: devel@edk2.groups.io ; Leif Lindholm Subject: Re: Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal External email: Use caution opening links or attachments OVMF did a similare change on Time Driver

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-12 Thread Jeff Fan
timer event functions. Jeff From: Ashish Singhal via groups.io Date: 2021-10-12 23:38 To: Marc Zyngier; Ard Biesheuvel; Shanker Donthineni CC: edk2-devel-groups-io; Leif Lindholm; Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal + Shaker From

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-12 Thread Ashish Singhal via groups.io
From: Ashish Singhal Sent: Tuesday, October 12, 2021 10:32 AM To: Marc Zyngier Cc: Shanker Donthineni ; Ard Biesheuvel ; edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal   From: Marc Zyngier Sent: Tuesday, Oct

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-12 Thread Ashish Singhal via groups.io
From: Marc Zyngier Sent: Tuesday, October 12, 2021 10:27 AM To: Ashish Singhal Cc: Shanker Donthineni ; Ard Biesheuvel ; edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal   External email: Use caution opening links

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-12 Thread Ashish Singhal via groups.io
From: Marc Zyngier Sent: Tuesday, October 12, 2021 9:44 AM To: Ashish Singhal Cc: Ard Biesheuvel ; edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal   External email: Use caution opening links or attachments Ashi

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-12 Thread Ashish Singhal via groups.io
+ Shaker Get Outlook for iOS From: Ashish Singhal Sent: Tuesday, October 12, 2021 8:56:58 AM To: Marc Zyngier ; Ard Biesheuvel Cc: edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-12 Thread Ashish Singhal via groups.io
Marc, In the document ARM062-1010708621-30 (AArch64 Programmer's Guides Generic Timer), towards the end of section 3.4 it says: "When writing an interrupt handler for the timers, it is important that software clears the interrupt before deactivating the interrupt in the GIC. Otherwise, the GIC

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-11 Thread Ard Biesheuvel
(+ Marc) On Mon, 11 Oct 2021 at 23:40, Ashish Singhal wrote: > > In an interrupt handler for the timers, it is important that > software clears the interrupt before deactivating the interrupt > in the GIC. Otherwise the GIC will re-signal the same interrupt > again. > > Signed-off-by: Ashish Sing

[edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-11 Thread Ashish Singhal via groups.io
In an interrupt handler for the timers, it is important that software clears the interrupt before deactivating the interrupt in the GIC. Otherwise the GIC will re-signal the same interrupt again. Signed-off-by: Ashish Singhal --- ArmPkg/Drivers/TimerDxe/TimerDxe.c | 9 + 1 file changed,