Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-10-01 Thread Laszlo Ersek
On 09/30/20 03:04, Gao, Zhichao wrote: > If the maintainers/reviewers don't have response for more than two weeks, you > can always push them. If initial feedback does not appear in *one* week, pinging the maintainer is justified. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You rec

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-29 Thread Gao, Zhichao
eda ; Wu, Jiaxin ; Fu, > Siyuan ; Ni, Ray ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 09/29/20 04:29, Gao, Zhichao wrote: > > Hi, > > > > I have checked in openCI and it is pa

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-29 Thread Gao, Zhichao
Hi Vladimir, It is a bug fix for http. It is part of NetworkPkg. I see you already add the maintainer and reviewer in the Cc list. Sometimes, the maintainers/reviewers may be busy at other work and miss the patch. You can remind and push them for review. If the maintainers/reviewers don't have

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-29 Thread Laszlo Ersek
On 09/29/20 04:29, Gao, Zhichao wrote: > Hi, > > I have checked in openCI and it is passed. > > Reviewed-by: Zhichao Gao > > Hi Laszlo, > > Do you have a plan to test this patch? Yep, I've been watching this thread as well. I'm happy that you are OK with v13, and so v13 is about to be merged.

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-29 Thread Vladimir Olovyannikov via groups.io
Hi Zhichao, Thank you for review. There is another commit waiting for review, which is related to Http, but it is not related to ShellPkg: https://edk2.groups.io/g/devel/message/64765 If one has a server which replies with Content-type: HTML, but does not send the Content-Length field, this con

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-28 Thread Gao, Zhichao
Hi, I have checked in openCI and it is passed. Reviewed-by: Zhichao Gao Hi Laszlo, Do you have a plan to test this patch? Thanks, Zhichao > -Original Message- > From: Vladimir Olovyannikov > Sent: Friday, September 25, 2020 4:41 AM > To: devel@edk2.groups.io > Cc: Vladimir Olovyanni

[edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-24 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy