Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-12 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
Attar, AbdulLateef (Abdul Lateef) ; Wu, Jiaxin Cc: Grimes, Paul ; Chang, Abner ; Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann ; Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Holthaus, CJ Subject: RE: [edk2-devel] [PATCH v11 0/8]

Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-11 Thread Ni, Ray
inney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ard > Biesheuvel ; Yao, Jiewen ; > Justen, Jordan L ; Holthaus, CJ > > Subject: Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib > > > UefiCpuPkg: Adds MmSaveStateLib library clas

Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-11 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
: Grimes, Paul ; Chang, Abner ; Eric Dong ; Ray Ni ; Rahul Kumar ; Gerd Hoffmann ; Michael D Kinney ; Liming Gao ; Zhiguang Liu ; Ard Biesheuvel ; Jiewen Yao ; Jordan Justen Subject: Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Caution: This message originated

Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-10 Thread Ni, Ray
> UefiCpuPkg: Adds MmSaveStateLib library class You can take "Reviewed-by: Ray Ni " for this patch. > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code You can take "Reviewed-by: Ray Ni " for this patch. > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family One comment: can you

Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-09 Thread Michael Kubacki
I haven't followed the whole thread but looking at v11, I wanted to check on the following. 1. The library source files (for AmdMmSaveStateLib and IntelMmSaveStateLib) include several library headers (particularly in MmSaveStateLib/MmSaveState.h) but do not have a [LibraryClasses] section in

Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-08 Thread Gerd Hoffmann
On Sat, May 06, 2023 at 09:36:56AM +0530, Abdul Lateef Attar wrote: > PR: https://github.com/tianocore/edk2/pull/4341 > > V11: Delta changes > Drop the OVMF implementation of MmSaveStateLib Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-08 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi @Ray Ni, Could you please help to review this patch set as the Hard Freeze is coming soon? Thanks Abner > -Original Message- > From: Abdul Lateef Attar > Sent: Saturday, May 6, 2023 12:07 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul

[edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-05 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2/pull/4341 V11: Delta changes Drop the OVMF implementation of MmSaveStateLib V10: Delta changes: Addressed review comments from Abner. V9: Delta changes: Addressed review comments. Rename to MmSaveStateLib. Also rename SMM_ defines to MM_. Implemented