Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-09 Thread Laszlo Ersek
Hi Vladimir, On 09/09/20 19:15, Vladimir Olovyannikov via groups.io wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, September 9, 2020 3:51 AM >> To: Vladimir Olovyannikov ; >> Rabeda, Maciej ; devel@edk2.groups.io; >> Zhichao Gao ; Ray Ni >> Cc: Samer El-Haj-Mahmou

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-09 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 9, 2020 3:51 AM > To: Vladimir Olovyannikov ; > Rabeda, Maciej ; devel@edk2.groups.io; > Zhichao Gao ; Ray Ni > Cc: Samer El-Haj-Mahmoud ; Jiaxin Wu > ; Siyuan Fu ; Liming Gao > ; Nd > Subject: Re: [PATCH v10 1/1] She

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-09 Thread Laszlo Ersek
On 09/08/20 23:04, Vladimir Olovyannikov wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Monday, September 7, 2020 2:37 AM >> To: Vladimir Olovyannikov ; >> Rabeda, Maciej ; devel@edk2.groups.io; >> Zhichao Gao ; Ray Ni >> Cc: Samer El-Haj-Mahmoud ; Jiaxin Wu >> ; Siyuan Fu ;

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-08 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Monday, September 7, 2020 2:37 AM > To: Vladimir Olovyannikov ; > Rabeda, Maciej ; devel@edk2.groups.io; > Zhichao Gao ; Ray Ni > Cc: Samer El-Haj-Mahmoud ; Jiaxin Wu > ; Siyuan Fu ; Liming Gao > ; Nd > Subject: Re: [PATCH v10 1/1] ShellP

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-07 Thread Laszlo Ersek
On 09/04/20 19:55, Vladimir Olovyannikov wrote: > There is also another issue with the TimebaseLib: inconsistency in return > values of the > EfiTimeToEpoch (returns UINT32, should return UINTN, as Zhichao pointed out > earlier in the previous HttpDynamicCommand patchset). > If this one is fixed,

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-04 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, Macieji, Thank you for spotting these. Some comments below. > -Original Message- > From: Laszlo Ersek > Sent: Friday, September 4, 2020 8:21 AM > To: Rabeda, Maciej ; Vladimir Olovyannikov > ; devel@edk2.groups.io; Zhichao > Gao ; Ray Ni > Cc: Samer El-Haj-Mahmoud ; Jiaxin Wu

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-04 Thread Laszlo Ersek
question for Ray and Zhichao at the bottom On 09/04/20 15:10, Rabeda, Maciej wrote: > Hi Vladimir, > > One remark regarding these macros: > #define SEC_PER_MONTH   ((UINTN) 2,592,000) > #define SEC_PER_YEAR    ((UINTN) > 31,536,000)

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-04 Thread Maciej Rabeda
Hi Vladimir, One remark regarding these macros: #define SEC_PER_MONTH   ((UINTN) 2,592,000) #define SEC_PER_YEAR    ((UINTN) 31,536,000) They are not being used in your code and were most probably taken from EmbeddedPkg/Include/Lib

[edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-01 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy