Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-04-17 Thread Gerd Hoffmann
On Wed, Apr 17, 2024 at 03:43:30PM +0800, Chao Li wrote: > Hi Gerd, > > > Thanks, > Chao > On 2024/4/17 14:59, Gerd Hoffmann wrote: > > On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote: > > > Hi Gerd, > > > > > > Part 2 has been be merged, I'm separating  this Lib into two serve the PEI >

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-04-17 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/4/17 14:59, Gerd Hoffmann wrote: On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote: Hi Gerd, Part 2 has been be merged, I'm separating  this Lib into two serve the PEI stage and DXE stage. Currently, This DXE library uses three global variables, and when I

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-04-16 Thread Gerd Hoffmann
On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote: > Hi Gerd, > > Part 2 has been be merged, I'm separating  this Lib into two serve the PEI > stage and DXE stage. > > Currently, This DXE library uses three global variables, and when I simulate > the no-mmio version: MmioLib.c + Dxe.c + Pei

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-04-16 Thread Chao Li
Hi Gerd, Part 2 has been be merged, I'm separating  this Lib into two serve the PEI stage and DXE stage. Currently, This DXE library uses three global variables, and when I simulate the no-mmio version: MmioLib.c + Dxe.c + Pei.c, I can abstract some helper functions as the public functions i

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-21 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/21 19:39, Gerd Hoffmann wrote: Hi, QemuFwCfgLibMmio.inf is looks like a DXE stage library, while this patch is the PEI stage library we are dicussing. I have tow plans: *Plan A:* Keep this library under LoongArchQemuVirt. *Plan  B:* Create a new INF named

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-21 Thread Gerd Hoffmann
Hi, > QemuFwCfgLibMmio.inf is looks like a DXE stage library, while this patch is > the PEI stage library we are dicussing. > > I have tow plans: > > *Plan A:* Keep this library under LoongArchQemuVirt. > > *Plan  B:* Create a new INF named QemuFwCfgPeiLibMmio.inf under > OvmfPkg/Library/Qemu

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-20 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/20 18:16, Gerd Hoffmann wrote: On Mon, Mar 18, 2024 at 04:28:17PM +0100, Gerd Hoffmann wrote: On Sat, Mar 16, 2024 at 10:17:00AM +0800, lixianglai wrote: Hi Gerd: On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: This library for PEI phase, and obtains

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-20 Thread Gerd Hoffmann
On Mon, Mar 18, 2024 at 04:28:17PM +0100, Gerd Hoffmann wrote: > On Sat, Mar 16, 2024 at 10:17:00AM +0800, lixianglai wrote: > > Hi Gerd: > > > On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: > > >> This library for PEI phase, and obtains the QemuFwCfg base address by > > >> directly parsi

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-18 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/18 23:28, Gerd Hoffmann wrote: On Sat, Mar 16, 2024 at 10:17:00AM +0800, lixianglai wrote: Hi Gerd: On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: This library for PEI phase, and obtains the QemuFwCfg base address by directly parsing the FDT, reads a

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-18 Thread Gerd Hoffmann
On Sat, Mar 16, 2024 at 10:17:00AM +0800, lixianglai wrote: > Hi Gerd: > > On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: > >> This library for PEI phase, and obtains the QemuFwCfg base address by > >> directly parsing the FDT, reads and writes the data in QemuFwCfg by > >> operating on t

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: > This library for PEI phase, and obtains the QemuFwCfg base address by > directly parsing the FDT, reads and writes the data in QemuFwCfg by > operating on the QemuFwCfg base address. > create mode 100644 > OvmfPkg/LoongArchVirt/Library/F

[edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-11 Thread Chao Li
This library for PEI phase, and obtains the QemuFwCfg base address by directly parsing the FDT, reads and writes the data in QemuFwCfg by operating on the QemuFwCfg base address. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Ger