Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-26 Thread Guo, Gua
Subject: Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support Hi Gua, Thanks for the review. Do you have a proposal or small example on how you want to separate into another FV? Thanks, Sheng On Wed, 26 Apr 2023 at 14:55, Guo, Gua mailto:gua@intel.com>> wrote: Do we se

Re: [edk2-devel] [PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-26 Thread Benjamin Doron
I hadn't seen the bugzilla yet, though I know the issue. See patch 1/2, the current approach is to use RngLibTimerLib if the build-time configuration indicates. This isn't recommended but sufficient for building for platforms which require the library class - I think OpensslLib has a dependency.

Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-26 Thread Pedro Falcato
On Tue, Apr 25, 2023 at 6:09 PM Benjamin Doron wrote: > > From: Benjamin Doron > > Uses CPU RDRAND support and installs the EfiRngProtocol. > The protocol may be used by iPXE or the Linux kernel to gather entropy. > > Cc: Guo Dong > Cc: Ray Ni > Cc: Sean Rhodes > Cc: James Lu > Cc: Gua Guo >

Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-26 Thread Sheng Lean Tan
n > *Cc:* devel@edk2.groups.io; Dong, Guo ; Ni, Ray < > ray...@intel.com>; Lu, James ; Guo, Gua < > gua@intel.com> > *Subject:* Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG > support > > > > Reviewed-by: Sean Rhodes > > > > O

Re: [edk2-devel] [PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-26 Thread Sheng Lean Tan
Hi Gua, Thanks for the review. Do you have a proposal or small example on how you want to see to separate into another FV? Thanks, Sheng -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103648): https://edk2.groups.io/g/devel/message/1036

Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-26 Thread Guo, Gua
: Benjamin Doron Cc: devel@edk2.groups.io; Dong, Guo ; Ni, Ray ; Lu, James ; Guo, Gua Subject: Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support Reviewed-by: Sean Rhodes mailto:sean@starlabs.systems>> On Tue, 25 Apr 2023 at 18:09, Benjamin Doron mailto:benjamin.doro...@gma

Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-26 Thread Sean Rhodes
Reviewed-by: Sean Rhodes On Tue, 25 Apr 2023 at 18:09, Benjamin Doron wrote: > From: Benjamin Doron > > Uses CPU RDRAND support and installs the EfiRngProtocol. > The protocol may be used by iPXE or the Linux kernel to gather entropy. > > Cc: Guo Dong > Cc: Ray Ni > Cc: Sean Rhodes > Cc: Ja

[edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

2023-04-25 Thread Benjamin Doron
From: Benjamin Doron Uses CPU RDRAND support and installs the EfiRngProtocol. The protocol may be used by iPXE or the Linux kernel to gather entropy. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Benjamin Doron --- UefiPayloadPkg/UefiPayloadPkg.dsc | 3 ++