Re: [edk2-devel] [PATCH v1 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-07-09 Thread Rebecca Cran
Please fix the documentation block. It should go above the function, and use Doxygen style. Also, the commit message doesn't make sense to me - specifically ", it must," -- Rebecca Cran On 7/6/23 9:26 AM, Joey Vagedes wrote: Hi all, Do you have any concerns over the changes I've made t

Re: [edk2-devel] [PATCH v1 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-07-06 Thread Joey Vagedes via groups.io
Hi all, Do you have any concerns over the changes I've made to GenFw.c as seen above? Please let me know if you have any questions, concerns, or improvements; I would be happy to help! Thanks, Joey On Fri, Jun 23, 2023 at 8:44 AM Joey Vagedes wrote: > Automatically set the nxcompat flag in the

[edk2-devel] [PATCH v1 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-06-23 Thread Joey Vagedes
Automatically set the nxcompat flag in the DLL Characteristics field of the Optional Header of the PE32+ image. For this flag to be set automatically, it must, the section alignment must be evenly divisible by 4K (EFI_PAGE_SIZE) and no section must be executable and writable. Cc: Rebecca Cran Cc: