ysztof Koch
> Sent: Tuesday, August 6, 2019 6:45 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Carsey, Jaben ; Ni, Ray ;
> Sami Mujawar ; Matteo Carlini
> ; nd
> Subject: Re: [edk2-devel] [PATCH v1 1/6] ShellPkg: acpiview: DBG2: Prevent
> buffer overruns
>
> Hi Zhich
n all parsers.
"""
Please let me know what you think.
Kind regards,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
Groups.Io
Sent: Tuesday, August 6, 2019 8:43
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Sa
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Monday, August 5, 2019 4:21 PM
> To: Gao, Zhichao ; devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Sami Mujawar ; Matteo Carlini
> ; nd
> Subject: Re: [edk2-devel] [PATCH v1 1
Hi Zhichao,
The reason why processing of the Debug Device Information Structure is split
into:
1. loading the header
2. dumping the entire structure
Is because we want to let the users control how much of the structure is
dumped. This is important for backward compatibility of the acpiview tool
About DbgDevInfoHeaderParser and DbgDevInfoParser.
This patch would parse same DbgDevInfo twice, one for getting length, the other
for dumping structure info.
How about the following?
Add one parameter for DumpDbgDeviceInfo
STATIC
VOID
EFIAPI
DumpDbgDeviceInfo (
IN UINT8* Ptr,
OUT UINT32* L
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44775): https://edk2.groups.io/g/devel/message/44775
Mute This Topic: https://groups.io/mt/32676831/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: htt
Modify the DBG2 table parsing logic to prevent reading past the ACPI
buffer lengths provided.
Modify the signature of the DumpDbgDeviceInfo() function to make it
consistent with the ACPI structure processing functions in other
acpiview parsers. Now, the length of the Debug Device Information
Struc
