Re: [edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-27 Thread Joey Vagedes
Hi Michael, PeImage.h currently references rev 8.3 as the latest revision. The DLLCHARACTERISTICS field of the optional header existed in the revision, but I believe it was never added as it was not needed. I'm happy to add information to the header if needed, just let me know what you're looking

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-27 Thread Michael D Kinney
Sounds like 9.3 would be better for consistent names. Mike From: Joey Vagedes Sent: Tuesday, June 27, 2023 2:42 PM To: Kinney, Michael D Cc: devel@edk2.groups.io; Gao, Liming ; Liu, Zhiguang Subject: Re: [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics Hi Michael, PeImage.h

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-27 Thread Michael D Kinney
Hi Joey, Was the link to the PE/COFF specs that added these updated in the file header? Also, shouldn't it be DLL_CHARACTERISRICS instead of DLLCHARACTERISRICS? Mike > -Original Message- > From: Joey Vagedes > Sent: Friday, June 23, 2023 8:45 AM > To: devel@edk2.groups.io > Cc: Kinney,

[edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-23 Thread Joey Vagedes
Add the bit masks for DLL Characteristics, used within the optional header of a PE, to the PeImage.h header file. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Joey Vagedes --- MdePkg/Include/IndustryStandard/PeImage.h | 15 +++ 1 file changed, 15 insertions(