回复: [edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

2022-02-06 Thread gaoliming
v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference It looks like this hasn't been committed yet - I still get a crash when running acpiview on my Overdrive 1000 system, and see the original code is still on the latest master. Could someone commit it please? -- Rebecca Cran

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

2022-01-31 Thread Rebecca Cran
It looks like this hasn't been committed yet - I still get a crash when running acpiview on my Overdrive 1000 system, and see the original code is still on the latest master. Could someone commit it please? -- Rebecca Cran On 12/14/21 09:08, Sami Mujawar wrote: Hi Chris, Thanks for fixin

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

2021-12-14 Thread Sami Mujawar
Hi Chris, Thanks for fixing this issue. Reviewed-by: Sami Mujawar Regards, Sami Mujawar From: Chris Jones Date: Tuesday, 14 December 2021 at 12:38 To: devel@edk2.groups.io Cc: ray...@intel.com , zhichao@intel.com , rebe...@nuviainc.com , Sami Mujawar , nd Subject: [PATCH v1 1/1] Shel

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

2021-12-14 Thread Rebecca Cran
Reviewed-by: Rebecca Cran Thanks, I'm now seeing: ERROR: On Arm based systems, all cache properties must be provided in the cache type structure. Missing 'Write Policy Valid' flag. -- Rebecca Cran On 12/14/21 5:37 AM, Chris Jones wrote: Bugzilla: 3770 (https://bugzilla.tianocore.org/sh

[edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

2021-12-14 Thread Chris Jones
Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770) The PPTT parser in AcpiView incorrectly dereferences a pointer to FlagName when trying to log an error with the PPTT cache flags, which can lead to random crashes and other errors. Also fix some spacing in the error message to e