Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin

2023-02-16 Thread Michael D Kinney
; ; Kinney, Michael D ; Feng, Bob C ; Chen, Christine Cc: devel@edk2.groups.io; 'Michael Kubacki' Subject: 回复: [edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin Joey: This patch is good to me. Reviewed-by: Liming Gao mailto:gaolim...@byosoft.com.cn>> Dose thi

回复: [edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin

2023-02-14 Thread gaoliming via groups.io
-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin I received an Acked-by, but would like to request a Reviewed-by from a BaseTools maintainer. @gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn> I would like to request that this change be included in the stab

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin

2023-02-06 Thread Joey Vagedes
I received an Acked-by, but would like to request a Reviewed-by from a BaseTools maintainer. @gaolim...@byosoft.com.cn I would like to request that this change be included in the stable tag. This change updates edk2-pytool-library and edk2-pytool-extensions to the latest release, which brings in

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin

2023-02-03 Thread Michael Kubacki
Acked-by: Michael Kubacki On 2/1/2023 3:22 PM, Joey Vagedes wrote: This patch updates edk2-pytool-library dependency to v0.13.0, which has an interface change to FindWithVsWhere. The BaseTools plugin uses this function, so it is being updated to account for the interface change. Cc: Bob Feng

[edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin

2023-02-01 Thread Joey Vagedes
This patch updates edk2-pytool-library dependency to v0.13.0, which has an interface change to FindWithVsWhere. The BaseTools plugin uses this function, so it is being updated to account for the interface change. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Michael D Kinney Signed-off-by: J