Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Rebecca Cran
Reviewed-by: Rebecca Cran -- Rebecca Cran On 11/6/2023 1:12 PM, Joey Vagedes wrote: Clarify to users that they should review the build log when make (POSIX-like system) or nmake (Windows) fails to compile basetools. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by

[edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Joey Vagedes via groups.io
Clarify to users that they should review the build log when make (POSIX-like system) or nmake (Windows) fails to compile basetools. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Edk2ToolsBuild.py | 8 ++-- 1 file changed, 6 insertio

[edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Joey Vagedes via groups.io
Clarify to users that they should review the build log when make (POSIX-like system) or nmake (Windows) fails to compile basetools. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Source/C/Common/BinderFuncs.c | 2 +- BaseTools/Edk2ToolsB