回复: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-07-16 Thread gaoliming via groups.io
Reviewed-by: Liming Gao 发件人: devel@edk2.groups.io 代表 Joey Vagedes via groups.io 发送时间: 2023年7月13日 23:27 收件人: Kinney, Michael D 抄送: devel@edk2.groups.io; Rebecca Cran ; Gao, Liming ; Feng, Bob C ; Chen, Christine 主题: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-07-13 Thread Rebecca Cran
Sorry I haven’t had a chance to look at it. I’ll try and find some time this weekend. On Thu, Jul 13, 2023, at 9:26 AM, Joey Vagedes via groups.io wrote: > Thank you for the review Michael. @Rebecca Cran > , @Liming Gao > have you had

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-07-13 Thread Joey Vagedes via groups.io
Thank you for the review Michael. @Rebecca Cran , @Liming Gao have you had time to take a look at this? It is a fairly simple change, following the same logic as xdrlib with a few modifications to use some newer python functionality. Thanks, Joey On Tue, Jun 27, 2023 at 10:21 AM Kinney, Michael

[edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-06-27 Thread Joey Vagedes
Removes the dependency on xdrlib and replaces it with custom logic to pack a per the xdr requirements. Necessary as xdrlib is being deprecated in python 3.13. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael D Kinney Signed-off-by: Joey Vagedes --- BaseTools/Scripts/B

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-06-27 Thread Michael D Kinney
Thank you for fixing this. Reviewed-by: Michael D Kinney > -Original Message- > From: Joey Vagedes > Sent: Tuesday, June 27, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Chen, > Christine ; Kinney, Michael D > > Subject: [PATCH v1 1/1] Base