Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Maciej Rabeda
j.rab...@linux.intel.com Subject: RE: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow. Reviewed-by: Siyuan Fu -Original Message- From: devel@edk2.groups.io On Behalf Of Laszlo Ersek Sent: 2020年3月25日 19:34 To: Ni, Ray ; Gao, Zhichao Cc: devel@edk2.groups

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Gao, Zhichao
Acked-by: Zhichao Gao > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, March 31, 2020 7:54 PM > To: devel@edk2.groups.io; ler...@redhat.com; Ni, Ray ; > Gao, Zhichao > Cc: maciej.rab...@linux.intel.com > Subject: RE: [edk2-devel] [PATCH v1] ShellPkg: F

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: 2020年3月25日 19:34 > To: Ni, Ray ; Gao, Zhichao > Cc: devel@edk2.groups.io; maciej.rab...@linux.intel.com > Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: F

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Maciej Rabeda
this patch? Thanks, Zhichao -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, March 25, 2020 7:34 PM To: Ni, Ray ; Gao, Zhichao Cc: devel@edk2.groups.io; maciej.rab...@linux.intel.com Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' c

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-25 Thread Gao, Zhichao
5, 2020 7:34 PM > To: Ni, Ray ; Gao, Zhichao > Cc: devel@edk2.groups.io; maciej.rab...@linux.intel.com > Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 > receive flow. > > Ray, Zhichao, > > On 02/27/20 12:02, Maciej Rabeda wrote: > > RE

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-25 Thread Laszlo Ersek
Ray, Zhichao, On 02/27/20 12:02, Maciej Rabeda wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032 > > 'ping' command's receive flow utilizes a single Rx token which it > attempts to reuse before recycling the previously received packet. > This causes a situation where under ICMP tr

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-02 Thread Liming Gao
> ; Kinney, Michael D > ; Andrew Fish ; Leif Lindholm > (Linaro address) > Cc: Ni, Ray ; Gao, Zhichao ; Armour, > Nicholas ; Fu, Siyuan > ; Wu, Jiaxin > Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive > flow. > > Liming, >

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-28 Thread Maciej Rabeda
bruary 28, 2020 7:42 PM To: devel@edk2.groups.io; Gao, Liming ; Laszlo Ersek ; Kinney, Michael D ; Andrew Fish ; Leif Lindholm (Linaro address) Cc: Ni, Ray ; Gao, Zhichao ; Armour, Nicholas ; Fu, Siyuan ; Wu, Jiaxin Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-28 Thread Liming Gao
gt; Nicholas ; Fu, Siyuan > ; Wu, Jiaxin > Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive > flow. > > Laszlo, > > Thanks for the detailed response on the patch. Always happy to learn > about stuff from the past. > > Li

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-28 Thread Maciej Rabeda
@edk2.groups.io; maciej.rab...@linux.intel.com; Gao, Liming ; Kinney, Michael D ; Andrew Fish ; Leif Lindholm (Linaro address) Cc: Ni, Ray ; Gao, Zhichao ; Armour, Nicholas Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow. On 02/27/20 14:14, Las

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-27 Thread Liming Gao
> ; Andrew Fish ; Leif Lindholm > (Linaro address) > Cc: Ni, Ray ; Gao, Zhichao ; Armour, > Nicholas > Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive > flow. > > On 02/27/20 14:14, Laszlo Ersek wrote: > > (+Liming and stewards;

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-27 Thread Laszlo Ersek
On 02/27/20 14:14, Laszlo Ersek wrote: > (+Liming and stewards; CC Nick) > > On 02/27/20 12:02, Maciej Rabeda wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032 >> >> 'ping' command's receive flow utilizes a single Rx token which it >> attempts to reuse before recycling the previou

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-27 Thread Laszlo Ersek
(+Liming and stewards; CC Nick) On 02/27/20 12:02, Maciej Rabeda wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032 > > 'ping' command's receive flow utilizes a single Rx token which it > attempts to reuse before recycling the previously received packet. > This causes a situation w

[edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-27 Thread Maciej Rabeda
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032 'ping' command's receive flow utilizes a single Rx token which it attempts to reuse before recycling the previously received packet. This causes a situation where under ICMP traffic, Ping6OnEchoReplyReceived() function will receive an alread