Thanks Nate!
Best Regards,
Xiaoqiang Zhang
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, February 9, 2022 11:27 AM
To: Zhang, Xiaoqiang ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Oram, Isaac W
Subject: RE: [PATCH v1] MinPlatformPkg: Install memory relating PPIs
Pushed
Pushed: https://github.com/tianocore/edk2-platforms/commit/b6f9674
> -Original Message-
> From: Zhang, Xiaoqiang
> Sent: Monday, February 7, 2022 12:11 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
>
> Subject: [PATCH v1]
Hi Isaac,
I think you might be a little confused about how these PCDs operate. Here is
the truth table:
Mode
PcdFspWrapperBootMode
PcdFspModeSelection
EDK II Native Mode
FALSE
N/A
FSP Dispatch Mode
TRUE
0
FSP API Mode
TRUE
1
So, this change modifies the if statement to read:
Good catch Xiaoqiang!
Reviewed-by: Nate DeSimone
-Original Message-
From: Zhang, Xiaoqiang
Sent: Monday, February 7, 2022 12:11 AM
To: devel@edk2.groups.io
Cc: Zhang, Xiaoqiang ; Chiu, Chasel
; Desimone, Nathaniel L
; Oram, Isaac W
Subject: [PATCH v1] MinPlatformPkg: Install memory
This has uncovered another issue that we should fix so that this isn't
necessary.
Since UEFI native code is all about binary interoperability, there should be no
difference between native mode and FSP dispatch mode. FV are FV, PPI are PPI,
etc. These two PCD should mean the exact same thing a
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3824
Install memory relating PPIs for EDKII native build and FSP dispatch mode
Signed-off-by: Xiaoqiang Zhang
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
---
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMe
Thanks Xiaoqiang!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zhang, Xiaoqiang
> Sent: Monday, February 7, 2022 4:11 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> Subject: [PATCH v1] MinPlatformPkg: Instal
