Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in LocateHandleBuffer()

2023-08-31 Thread Michael D Kinney
ming > ; Wang, Jian J ; Bi, > Dandan > Subject: Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in > LocateHandleBuffer() > > A gentle ping :) > > https://edk2.groups.io/g/devel/message/92452 > > As MdeModulePkg/Core was modified, might it be po

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in LocateHandleBuffer()

2023-08-31 Thread Mike Maslenkin
A gentle ping :) https://edk2.groups.io/g/devel/message/92452 As MdeModulePkg/Core was modified, might it be possible to add more? Should I resend those patches? MdeModulePkg/Core maintainers didn't reply. Regards, MIke. On Thu, Aug 31, 2023 at 11:02 PM Nate DeSimone wrote: > > Hi Mike, > > I

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in LocateHandleBuffer()

2023-08-31 Thread Nate DeSimone
Hi Mike, I agree that it should be extremely rare for the 1st call to succeed AND the 2nd call to fail. The only case I can think of where that could happen is if the call to AllocatePool() in CoreFindProtocolEntry() fails due to an out of memory scenario. As always thank you for your careful r

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in LocateHandleBuffer()

2023-08-31 Thread Michael D Kinney
Hi Nate, I do not disagree with the logic of the patch. Reviewed-by: Michael D Kinney However, I do not understand how the 1st call to InternalCoreLocateHandle() can succeed and the 2nd call can fail if the handle database protocol lock is in the acquired state. Is there a real scenario where

[edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in LocateHandleBuffer()

2023-08-30 Thread Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4543 REF: https://uefi.org/specs/UEFI/2.10/07_Services_Boot_Services.html#efi-boot-services-locatehandlebuffer CoreLocateHandleBuffer() can in certain cases, can return an error and not free an allocated buffer. This scenario occurs if the first