Re: [edk2-devel] [PATCH V9 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-23 Thread Min Xu
On March 23, 2022 3:20 PM, Ni Ray wrote: > Min, > MpInitLib contains following APIs. Let's discuss one by one. > > MpInitLibInitialize: Directly return. Looks good to me. > MpInitLibGetNumberOfProcessors : Call TdxMpInitLibGetNumberOfProcessors(). > Why call a subfunction here but directly return

Re: [edk2-devel] [PATCH V9 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-23 Thread Ni, Ray
Min, MpInitLib contains following APIs. Let's discuss one by one. MpInitLibInitialize: Directly return. Looks good to me. MpInitLibGetNumberOfProcessors : Call TdxMpInitLibGetNumberOfProcessors(). Why call a subfunction here but directly return in above API? Not quite consistent to me. By the wa

Re: [edk2-devel] [PATCH V9 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-21 Thread Min Xu
Hi, Ray Can you help to review this patch? https://edk2.groups.io/g/devel/message/87690 Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87815): https://edk2.groups.io/g/devel/message/87815 Mute This Topic: https://groups.io/mt/

[edk2-devel] [PATCH V9 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-17 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others are treated as APs. So MP intialization is rather simple. The processor info is retrieved by TDCALL, ApWorker is not supported, BSP is always the working processor, whi