Re: [edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions

2022-03-07 Thread Min Xu
On March 2, 2022 2:57 PM, Gerd Hoffmann wrote: > Hi, > > > > Hmm. Unlike patches 17+18 which are pure code motion (except the > > > function renaming but that doesn't change the workflow) this patch > > > mixes code changes and code moving which makes it hard to review. > > > > > > It should be

Re: [edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions

2022-03-02 Thread Gerd Hoffmann
Hi, > > Hmm. Unlike patches 17+18 which are pure code motion (except the > > function renaming but that doesn't change the workflow) this patch mixes > > code changes and code moving which makes it hard to review. > > > > It should be splitted into one (or more) patches changing the functions

Re: [edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions

2022-03-01 Thread Min Xu
On March 1, 2022 9:10 PM, Gerd Hoffmann wrote: > On Mon, Feb 28, 2022 at 03:20:51PM +0800, Min Xu wrote: > > Below functions are introduced in PlatformInitLib: > > - PlatformGetFirstNonAddress > > - PlatformAddressWidthInitialization > > - PlatformGetSystemMemorySizeBelow4gb > > - PlatformQemuU

Re: [edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions

2022-03-01 Thread Gerd Hoffmann
On Mon, Feb 28, 2022 at 03:20:51PM +0800, Min Xu wrote: > Below functions are introduced in PlatformInitLib: > - PlatformGetFirstNonAddress > - PlatformAddressWidthInitialization > - PlatformGetSystemMemorySizeBelow4gb > - PlatformQemuUc32BaseInitialization > - PlatformInitializeRamRegions >

[edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions

2022-02-27 Thread Min Xu
Below functions are introduced in PlatformInitLib: - PlatformGetFirstNonAddress - PlatformAddressWidthInitialization - PlatformGetSystemMemorySizeBelow4gb - PlatformQemuUc32BaseInitialization - PlatformInitializeRamRegions They correspond to the below functions in OvmfPkg/PlatformPei: - GetF