Re: [edk2-devel] [PATCH V6] BaseTools:Add the spare space FV image size checker

2020-04-19 Thread Liming Gao
Zhiju: With this improvement, Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Monday, April 20, 2020 9:17 AM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: RE: [PATCH V6] BaseTools:Add the spare space FV image size checker > > Hi LiMing

Re: [edk2-devel] [PATCH V6] BaseTools:Add the spare space FV image size checker

2020-04-19 Thread Fan, ZhijuX
Hi LiMing, I agree with this change and will improve it Any question, please let me know. Thanks. Best Regards Fan Zhiju > -Original Message- > From: Gao, Liming > Sent: Wednesday, April 15, 2020 9:21 PM > To: Fan, ZhijuX ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: RE: [PA

Re: [edk2-devel] [PATCH V6] BaseTools:Add the spare space FV image size checker

2020-04-15 Thread Liming Gao
Zhiju: Thanks for your update. The change is good to me. For the report error message, I suggest as below xx FV free space is not enough to meet with the required spare space set by -D FV_SPARE_SPACE_THRESHOLD option. Thanks Liming > -Original Message- > From: Fan, ZhijuX >

[edk2-devel] [PATCH V6] BaseTools:Add the spare space FV image size checker

2020-04-15 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the s