Re: [edk2-devel] [PATCH V5] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-26 Thread Bob Feng
Zhiju, I have 2 comments on the code style. Inline. On Thu, Mar 26, 2020 at 03:57 PM, Fan, ZhijuX wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2538 > > For LzmaCompress or BrotliCompress, the platform may use the different > options and add their batch file, such as LzmaCompr

[edk2-devel] [PATCH V5] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-26 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt. *_*_*_LZMA_P