Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-13 Thread Brian J. Johnson
v Cc: Andrew Fish , Marvin Häuser , liming.gao , Gao, Zhichao Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions O. Does that mean we get to start on DebugLibEx? In all seriousness, I’m also in the camp of “can’t we just drop these asser

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-13 Thread Vitaly Cheptsov
002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask > & 0xC0) == 0 > - gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0|UINT8|0x0005 > - > ## This flag is used to control the print out Debug message. > # BIT0 - Initialization message. > # BIT1 - Warning message. >

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-13 Thread Liming Gao
fail when the module writer followed all the > > rules. This is why including a libclass from another > > libclass is bad idea. > > > > Mike > > > >> -Original Message- > >> From: devel@edk2.groups.io On > >> Behalf Of Laszlo Ersek &

Re: [EXTERNAL] Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-13 Thread Bret Barkelew via groups.io
: Kinney, Michael D ; devel@edk2.groups.io ; Vitaly Cheptsov Cc: Andrew Fish ; Marvin Häuser ; liming.gao ; Gao, Zhichao Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions Hi Mike, On 05/12/20 20:18, Kinney, Michael D wrote: > What if there i

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-13 Thread Laszlo Ersek
Hi Mike, On 05/12/20 20:18, Kinney, Michael D wrote: > What if there is a > DebugLib implementation of the DebugLib class that > does not depend on DebugCommonLib. There need not be a link failure in this case either, if the DebugLib instance in question provides the DebugCommonLib API impleme

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-12 Thread Vitaly Cheptsov
nt: Tuesday, May 12, 2020 2:51 AM >> To: Kinney, Michael D ; >> Vitaly Cheptsov ; >> devel@edk2.groups.io >> Cc: Andrew Fish ; Marvin Häuser >> ; Gao, Liming >> ; Gao, Zhichao >> >> Subject: Re: [edk2-devel] [PATCH V4 00/27] Disabling >> safe st

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-12 Thread Michael D Kinney
sov ; > devel@edk2.groups.io > Cc: Andrew Fish ; Marvin Häuser > ; Gao, Liming > ; Gao, Zhichao > > Subject: Re: [edk2-devel] [PATCH V4 00/27] Disabling > safe string constraint assertions > > On 05/12/20 00:40, Kinney, Michael D wrote: > > Vitaly, > > >

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-12 Thread Vitaly Cheptsov
Hello everyone, Let me try in order. After an internal review I added the following to SafeString commit message: Note, for packages with constraint assertions disabled this change turn off the assertions on constraint violations. This is obvious, and I believe everyone agreed it is not healthy e

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-12 Thread Laszlo Ersek
On 05/12/20 00:40, Kinney, Michael D wrote: > Vitaly, > > Thank you for the contribution. > > There are a couple points about this approach that need to be discussed. > > You have included the from > MdePkg/Include/Library/DebugLib.h. Right, I've noticed it. I agree it's unusual. I didn't thi

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-11 Thread Michael D Kinney
Vitaly, Thank you for the contribution. There are a couple points about this approach that need to be discussed. You have included the from MdePkg/Include/Library/DebugLib.h. It is very rare for a lib class to include another lib class. This means that a module that has a dependency on the

[edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-11 Thread Vitaly Cheptsov
Cc: Andrew Fish Cc: Mike Kinney Cc: Marvin Häuser Cc: Liming Gao Cc: Zhichao Gao CC: Laszlo Ersek This changesest hopefully finally resolves the longstanding https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Requesting to merge into edk2-stable202005. Vitaly Cheptsov (27): MdePkg: Intr