New patch set send to my fork branch:
https://github.com/ZhichaoGao/edk2/commits/deprecated_algo
Take all the comments and add Jian's R-B.
V5 changes:
Fix incorrect symbol in patch #2.
Separate the patch #8 OpensslLib changes and create it thru change the
process_files.pl.
Change the incorrect A
Zhichao
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, May 14, 2020 10:49 AM
> To: Wang, Jian J ; devel@edk2.groups.io; Fu, Siyuan
> ; Kinney, Michael D ; Yao,
> Jiewen ; Philippe Mathieu-Daude
> ; Lu, XiaoyuX
> Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, May 13, 2020 9:49 PM
> To: Gao, Zhichao ; devel@edk2.groups.io; Fu, Siyuan
> ; Kinney, Michael D ; Yao,
> Jiewen ; Philippe Mathieu-Daude ;
> Lu, XiaoyuX
> Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functio
Zhichao,
Two general comments for improvement needed in your future patches:
1. Add r-b for those patch files which have got r-b
2. It'd be better to add summary of changes between this and previous version
of patches
For v4,
patch 8: the updates of OpensslLib should be done by process_fi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Retire below deprecated functions:
MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1.
V2:
Seprate the MD5 and SHA1 changes to other patch set.
Change the deprecated function wrapper implementatuion in
EDKII_CRYPTO_PROTOCOL to call a dummy