Re: [edk2-devel] [PATCH V4 0/4] CryptoPkg: Add EC support

2022-09-25 Thread Yao, Jiewen
Thanks. For patch 3/4: I don't think "TLS" is "public key related service". I suggest to change from + # 1) Platform needs ECC in public key related service, eg. Tls, X509, Pem. to + # 1) Platform needs ECC in TLS, or asymmetric cryptography services such as X509 certificate or PEM format data

[edk2-devel] [PATCH V4 0/4] CryptoPkg: Add EC support

2022-09-24 Thread yi1 li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 Review PR: https://github.com/tianocore/edk2/pull/3398 This patch sequence is used to add CryptEc library, which are wrapped over OpenSSL. The implementation provides library functions for EFI BaseCrypt protocol and EFI BaseCrypt Configurati