Re: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

2023-05-08 Thread Minh Nguyen
Hi Pedro, I just re-sent in readable format. Thanks, Minh Nguyen On 5/7/2023 12:39 PM, Minh Nguyen wrote: Hi Pedro, Firstly, thanks for your comments, let me explain. - "C99 flexible array members have been well defined and well supported for maybe 20 years in GCC (https://godbolt.

Re: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

2023-05-08 Thread Minh Nguyen
Hi Pedro, Firstly, thanks for your comments, let me explain. - "C99 flexible array members have been well defined and well supported for maybe 20 years in GCC (https://godbolt.org/z/9qxKar4f6)" => *Yes, I agree and there's no** **comment from my side* *but this is completely different with curr

Re: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

2023-05-05 Thread Michael D Kinney
com; ig...@ami.com; n...@os.amperecomputing.com; > tinhngu...@os.amperecomputing.com; Vu Nguyen > ; Nick Ramirez > > Subject: Re: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on > Linux > > On Fri, May 5, 2023 at 6:12 PM Minh Nguyen via groups.io > wrote: > &g

Re: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

2023-05-05 Thread Pedro Falcato
On Fri, May 5, 2023 at 6:12 PM Minh Nguyen via groups.io wrote: > > From: Vu Nguyen > > It requires a fixed size array to store the content of device path PCD. > Add the array size to solve this issue. > > Signed-off-by: Minh Nguyen > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez

[edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

2023-05-05 Thread minhnampere via groups.io
From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5

[edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

2023-05-05 Thread Minh Nguyen via groups.io
From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5