Re: [edk2-devel] [PATCH V3 4/8] CryptoPkg/BaseCryptLib: Retire the Tdes algorithm

2020-05-08 Thread Wang, Jian J
Zhichao, Similar comments, please refer to them in my review email for patch 3. Regards, Jian > -Original Message- > From: Gao, Zhichao > Sent: Thursday, May 07, 2020 7:58 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Fu, Siyuan ; Kinney, Michael D > ; Yao, Jiewen

Re: [edk2-devel] [PATCH V3 4/8] CryptoPkg/BaseCryptLib: Retire the Tdes algorithm

2020-05-07 Thread Philippe Mathieu-Daudé
On 5/7/20 1:57 AM, Gao, Zhichao wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Tdes is not secure any longer. Please write acronyms in caps: TDES. Remove the Tdes support from edk2. Change the Tdes field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported a

[edk2-devel] [PATCH V3 4/8] CryptoPkg/BaseCryptLib: Retire the Tdes algorithm

2020-05-06 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Tdes is not secure any longer. Remove the Tdes support from edk2. Change the Tdes field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney C