Re: [edk2-devel] [PATCH V3 3/9] OvmfPkg/IntelTdx: Add SecTdxHelperLib

2023-01-25 Thread Min Xu
Michael Roth > Subject: RE: [edk2-devel] [PATCH V3 3/9] OvmfPkg/IntelTdx: Add > SecTdxHelperLib > > Hey > I don't think it is a good idea to define a context size here, because that > will > assume the openssl implementation. Please don't do that. > > Could

Re: [edk2-devel] [PATCH V3 3/9] OvmfPkg/IntelTdx: Add SecTdxHelperLib

2023-01-25 Thread Yao, Jiewen
-- > From: Xu, Min M > Sent: Thursday, January 26, 2023 9:57 AM > To: devel@edk2.groups.io; kra...@redhat.com > Cc: Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Michael Roth > Subject: RE: [edk2-devel] [PATCH V3 3/9] OvmfPkg/IntelTdx: Add > SecTdxHelper

Re: [edk2-devel] [PATCH V3 3/9] OvmfPkg/IntelTdx: Add SecTdxHelperLib

2023-01-25 Thread Min Xu
On January 25, 2023 8:16 PM, Gerd Hoffmann wrote: > > +// > > +// SHA512_CTX is defined in and its size is 216 bytes. > > +// It can be built successfully with GCC5 compiler but failed with VS2019. > > +// The error code showed in VS2019 is that "openssl/sha.h" cannot be found. > > +// To overcome

Re: [edk2-devel] [PATCH V3 3/9] OvmfPkg/IntelTdx: Add SecTdxHelperLib

2023-01-25 Thread Gerd Hoffmann
> +// > +// SHA512_CTX is defined in and its size is 216 bytes. > +// It can be built successfully with GCC5 compiler but failed with VS2019. > +// The error code showed in VS2019 is that "openssl/sha.h" cannot be found. > +// To overcome this error SHA512_CTX_SIZE is defined. > +// > +#define SHA

[edk2-devel] [PATCH V3 3/9] OvmfPkg/IntelTdx: Add SecTdxHelperLib

2023-01-24 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob - TdxHelperMeasureTdHob - TdxHelperMeasureCfvImage - TdxHelperBuildGuidHobForTdxMeasurement SecTdxHelperLib is the SEC instance of TdxH