Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-09 Thread Minh Nguyen
Hi Abner,  Thanks for your information. Thanks, Minh Nguyen On 5/8/2023 8:45 PM, Chang, Abner wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] [AMD Official Use Only - G

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-08 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Minh, Just let you know your PR is just merged. Thanks Abner From: Minh Nguyen Sent: Friday, May 5, 2023 2:50 PM To: Chang, Abner ; Minh Nguyen ; devel@edk2.groups.io Cc: patc...@amperecomputing.com; nick...@nvidia.com; ig...@ami.com; n...@os.amperecomputin

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-05 Thread Minh Nguyen
Hi Abner,  I've updated. Thanks for your review. Thanks, Minh Nguyen On 5/5/2023 2:38 PM, Chang, Abner wrote: [AMD Official Use Only - General] Hi Minh, Please add my RB for 3/5 in commit message and push to minhnampere:Adding_necessary_changes_for_RedfishPkg again. I will check the PR a

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-05 Thread Minh Nguyen
Hi Abner,  While they're checking this issue, they recommend me to re-send v3 so I just sent it, you can also use the PR to review at the same time. Thanks, Minh Nguyen. On 5/5/2023 1:01 PM, Minh Nguyen wrote: Hi Abner,  Here you are: #4338 T

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-05 Thread Minh Nguyen
Hi Abner,  Here you are: #4338 Thanks, Minh Nguyen On 5/5/2023 12:45 PM, Chang, Abner wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection p

[edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-05 Thread minhnampere via groups.io
This patchset adds necessary changes for RedfishPkg to avoid some unexpected cases and fix compilation. Changes since v3: + Replaced __FUNCTION__ with __func__ to be more C11 compliant. Changes since v2: + Added "Cc:" to maintainers in commit message. + Corrected patch format subject prefix. C

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-05 Thread Minh Nguyen
Hi Abner,  Yes, me too. I have sent the email to miki.deme...@intel.com for checking it. Thanks, Minh Nguyen On 5/5/2023 12:03 PM, Chang, Abner wrote: [AMD Official Use Only - General] Hi Minh, I don't know why however I can't see V3 patch set on group.io. Can you see those patches on gro

[edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-05 Thread Minh Nguyen via groups.io
This patchset adds necessary changes for RedfishPkg to avoid some unexpected cases and fix compilation. Changes since v3: + Replaced __FUNCTION__ with __func__ to be more C11 compliant. Changes since v2: + Added "Cc:" to maintainers in commit message. + Corrected patch format subject prefix. C

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-05 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Minh, Please add my RB for 3/5 in commit message and push to minhnampere:Adding_necessary_changes_for_RedfishPkg again. I will check the PR and merge it once it passes CI. Thank for your contribution. Abner > -Original Message- > From: minhnampere

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Ok, because the patch in email always has format problem when apply the patch, plus I can't get the patch from group.io; could you please create a PR on your Github thus I can review patches from there. Just let me know the PR # after you creating it. Thanks Ab

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Minh, I don't know why however I can't see V3 patch set on group.io. Can you see those patches on group.io? Abner > -Original Message- > From: Minh Nguyen > Sent: Friday, May 5, 2023 11:58 AM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.