Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe

2022-10-25 Thread Nate DeSimone
Thanks for the review Michael, I've sent a V4 patch with the added @return > From: Michael Kubacki > Sent: Tuesday, October 25, 2022 3:03 PM > To: Desimone, Nathaniel L ; > devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory

Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe

2022-10-25 Thread Michael Kubacki
It would be nice to update @return for AllocateReservedMemoryBelow4G() to indicate NULL should be expected if an internal memory allocation fails. Other than that: Reviewed-by: Michael Kubacki -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onli

[edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe

2022-10-21 Thread Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4112 In AllocateReservedMemoryBelow4G(), if gBS->AllocatePages() returns an error, and ASSERTs are disabled, then the function will overwrite memory from 0x -> (0x + Size). Cc: Liming Gao Cc: Guomin Jiang Cc: Jian J Wang Cc: M