Re: [edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-11-06 Thread Yao, Jiewen
I do not see other protocol add such information in DEC file. But I am OK to add. Will do that in V3. > -Original Message- > From: Ni, Ray > Sent: Thursday, November 7, 2019 2:12 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Lou, Yun > > Subject: RE: [PATCH V2

Re: [edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-11-06 Thread Ni, Ray
Jiewen, Can you add comments to explain the protocol and the associated header file path? Like: ## Guid for EDKII implementation extension, used to indaicate there are bit fields in the varstore. # Include/Guid/MdeModuleHii.h gEdkiiIfrBitVarstoreGuid = {0x82DDD68B, 0x9163, 0x4187, {0x9B,

Re: [edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-11-06 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Yao, Jiewen Sent: Thursday, October 31, 2019 5:31 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Lou, Yun Subject: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition. REF: https://bugzilla.tianocore.org/

Re: [edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-11-05 Thread Yao, Jiewen
gt; Cc: Ni, Ray ; Chaganty, Rangasai V > ; Lou, Yun > Subject: [edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid > definition. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303 > > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Yun Lou > Sign

[edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-10-31 Thread Yao, Jiewen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Yun Lou Signed-off-by: Jiewen Yao --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Sili